[webkit-reviews] review granted: [Bug 220658] A DOMWindow should not be reused if its JSDOMWindow has been created : [Attachment 417810] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 10:39:56 PST 2021


Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 220658: A DOMWindow should not be reused if its JSDOMWindow has been
created
https://bugs.webkit.org/show_bug.cgi?id=220658

Attachment 417810: Patch

https://bugs.webkit.org/attachment.cgi?id=417810&action=review




--- Comment #10 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 417810
  --> https://bugs.webkit.org/attachment.cgi?id=417810
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417810&action=review

r=me

> Source/WebCore/page/DOMWindow.h:487
> +    bool m_wasWrappedWithoutInitializedDocument { false };

I would call this wasWrappedWithoutInitializedSecurityOrigin, since it's the
security origin that was not initialized.


More information about the webkit-reviews mailing list