[webkit-reviews] review granted: [Bug 220474] Web Inspector: Font Details sidebar - Fractional variation axis ranges/default values are rounded. : [Attachment 417701] Patch v1.5 - Revised approach for converting fractions to strings

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 220474: Web Inspector: Font Details sidebar - Fractional variation axis
ranges/default values are rounded.
https://bugs.webkit.org/show_bug.cgi?id=220474

Attachment 417701: Patch v1.5 - Revised approach for converting fractions to
strings

https://bugs.webkit.org/attachment.cgi?id=417701&action=review




--- Comment #12 from BJ Burg <bburg at apple.com> ---
Comment on attachment 417701
  --> https://bugs.webkit.org/attachment.cgi?id=417701
Patch v1.5 - Revised approach for converting fractions to strings

View in context: https://bugs.webkit.org/attachment.cgi?id=417701&action=review

r=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:5
> +localizedStrings[" (Range: %s-%s, Default: %s) @ Font Details Sidebar"] = "
(Range: %s-%s, Default: %s)";

Hopefully localizers can figure out the context based on the string.

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:78
> +localizedStrings["%s%%"] = "%s%%";

It would be wise to explain what this is with a localization comment.