[webkit-reviews] review granted: [Bug 220617] [WebAuthn] Polish the new WebAuthn UI : [Attachment 417751] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 220617: [WebAuthn] Polish the new WebAuthn UI
https://bugs.webkit.org/show_bug.cgi?id=220617

Attachment 417751: Patch

https://bugs.webkit.org/attachment.cgi?id=417751&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 417751
  --> https://bugs.webkit.org/attachment.cgi?id=417751
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417751&action=review

r=me

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinat
or.mm:-68
> -	   ASSERT(!RunLoop::isMain());

Why is it okay to remove this assertion? Should we be asserting that we are on
the main runloop when UI is being presented?