[webkit-reviews] review granted: [Bug 220636] [GTK] Multilib conflicts in gir files : [Attachment 417661] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 220636: [GTK] Multilib conflicts in gir files
https://bugs.webkit.org/show_bug.cgi?id=220636

Attachment 417661: Patch

https://bugs.webkit.org/attachment.cgi?id=417661&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 417661
  --> https://bugs.webkit.org/attachment.cgi?id=417661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417661&action=review

> Source/JavaScriptCore/PlatformGTK.cmake:83
> +	       --sources-top-dirs=${CMAKE_BINARY_DIR}
> +	       --sources-top-dirs=${CMAKE_SOURCE_DIR}

why do we need to pass both? do we want the toplevel soures dir or the toplevel
build dir?