[webkit-reviews] review granted: [Bug 220641] Add JSC API configuring GC signals in Linux : [Attachment 417760] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 220641: Add JSC API configuring GC signals in Linux
https://bugs.webkit.org/show_bug.cgi?id=220641

Attachment 417760: Patch

https://bugs.webkit.org/attachment.cgi?id=417760&action=review




--- Comment #12 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 417760
  --> https://bugs.webkit.org/attachment.cgi?id=417760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417760&action=review

r=me with suggested improvement.

> Source/WTF/wtf/posix/ThreadingPOSIX.cpp:80
> +int sigThreadSuspendResume { -1 };
> +bool sigThreadSuspendResumeIsFrozen { false };

Why not store these as fields in WTFConfig where they can actually get frozen?