[webkit-reviews] review granted: [Bug 220585] [JSC] Implement a B3::Compilation replacement for wasm-llint : [Attachment 417764] Move B3::Compilation to jit/, v1

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 220585: [JSC] Implement a B3::Compilation replacement for wasm-llint
https://bugs.webkit.org/show_bug.cgi?id=220585

Attachment 417764: Move B3::Compilation to jit/, v1

https://bugs.webkit.org/attachment.cgi?id=417764&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 417764
  --> https://bugs.webkit.org/attachment.cgi?id=417764
Move B3::Compilation to jit/, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=417764&action=review

r=me

> Source/JavaScriptCore/b3/air/testair.cpp:88
> +std::unique_ptr<JSC::Compilation> compile(B3::Procedure& proc)

JSC:: of JSC::Compilation is not necessary.

> Source/JavaScriptCore/b3/air/testair.cpp:95
> +    return makeUnique<JSC::Compilation>(

JSC:: is not necessary.

> Source/JavaScriptCore/b3/air/testair.cpp:100
> +T invoke(const JSC::Compilation& code, Arguments... arguments)

Ditto.

> Source/JavaScriptCore/ftl/FTLJITCode.h:55
> +    void initializeB3Byproducts(std::unique_ptr<JSC::OpaqueByproducts>);

JSC:: of JSC::OpaqueByproducts is not necessary.

> Source/JavaScriptCore/ftl/FTLJITCode.h:80
> +    std::unique_ptr<JSC::OpaqueByproducts> m_b3Byproducts;

Ditto.

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:50
> +    std::unique_ptr<JSC::OpaqueByproducts> wasmEntrypointByproducts;

Ditto

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:113
> +    function->entrypoint.compilation = makeUnique<JSC::Compilation>(

Ditto

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:229
> +	       m_wasmInternalFunctions[functionIndex]->entrypoint.compilation =
makeUnique<JSC::Compilation>(

Ditto.

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:241
> +	       embedderToWasmInternalFunction->entrypoint.compilation =
makeUnique<JSC::Compilation>(

Ditto

> Source/JavaScriptCore/wasm/WasmFormat.h:341
> +    std::unique_ptr<JSC::Compilation> compilation;

Ditto.

> Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:155
> +	       function->entrypoint.compilation = makeUnique<JSC::Compilation>(

Ditto.

> Source/JavaScriptCore/wasm/WasmOMGForOSREntryPlan.cpp:92
> +    omgEntrypoint.compilation = makeUnique<JSC::Compilation>(

Ditto

> Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:89
> +    omgEntrypoint.compilation = makeUnique<JSC::Compilation>(

Ditto.