[webkit-reviews] review granted: [Bug 220224] Support transferred min/max block size for aspect-ratio : [Attachment 417693] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 220224: Support transferred min/max block size for aspect-ratio
https://bugs.webkit.org/show_bug.cgi?id=220224

Attachment 417693: Patch

https://bugs.webkit.org/attachment.cgi?id=417693&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 417693
  --> https://bugs.webkit.org/attachment.cgi?id=417693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417693&action=review

> Source/WebCore/rendering/RenderBox.cpp:650
> +	   logicalWidth = std::max(logicalMinWidth, std::min(logicalWidth,
logicalMaxWidth));

I’m fond of using std::clamp for this sort of thing, but it’s maybe not
*exactly* the same as the std::max/min combo here.