[webkit-reviews] review granted: [Bug 220660] PiP video subtitles stop updating when Safari is backgrounded : [Attachment 417714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 15 16:05:01 PST 2021

Darin Adler <darin at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 220660: PiP video subtitles stop updating when Safari is backgrounded

Attachment 417714: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 417714
  --> https://bugs.webkit.org/attachment.cgi?id=417714

View in context: https://bugs.webkit.org/attachment.cgi?id=417714&action=review

> +    return m_isRenderingSuspended &&

This code is a little bit mysterious, not obvious. Hard to understand this is
about PIP and why it’s correct. There’s not even a why comment!

And worse, we have no regression test for this, so someone could break it and
commit the change without ever knowing it.

That’s bad combination: seems like we may be unable to keep this working and
might make the same kind of mistake again in the future.

More information about the webkit-reviews mailing list