[webkit-reviews] review granted: [Bug 220672] Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along. : [Attachment 417739] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 220672: Apple Mail AX, VoiceOver: When composing a new email message,
moving VO focus to the message body field does not bring keyboard focus along.
https://bugs.webkit.org/show_bug.cgi?id=220672

Attachment 417739: Patch

https://bugs.webkit.org/attachment.cgi?id=417739&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 417739
  --> https://bugs.webkit.org/attachment.cgi?id=417739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review

> Source/WebCore/ChangeLog:10
> +	   The call to AccessibilityObject::setFocused to set the focus to the
> +	   scroll view needs to happen before the check for
canSetFocusAttribute.

Normally we require a regression test when we fix a bug. Is there a way to fix
this?