[webkit-reviews] review granted: [Bug 219177] zero boundingRect pointer in Font::platformBoundsForGlyph() to CTFontGetBoundingRectsForGlyphs() : [Attachment 417743] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 219177: zero boundingRect pointer in Font::platformBoundsForGlyph() to
CTFontGetBoundingRectsForGlyphs()
https://bugs.webkit.org/show_bug.cgi?id=219177

Attachment 417743: Patch

https://bugs.webkit.org/attachment.cgi?id=417743&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 417743
  --> https://bugs.webkit.org/attachment.cgi?id=417743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417743&action=review

> Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:702
> +    CGRect ignoredRect = { };

No reason for the "= { }". The name emptyRect confused me into thinking it was
needed. So the only thing wrong was the name, the code was totally fine. This
patch is OK as is, but also one that just ranges would be fine. And the bug
could be retitled since this is just naming clarity, no need to zero anything.