[webkit-reviews] review denied: [Bug 220663] [GPUProcess] Claim ownership of IOSurface backing for ImageBufferBackends in the WebProcess : [Attachment 417719] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 220663: [GPUProcess] Claim ownership of IOSurface backing for
ImageBufferBackends in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=220663

Attachment 417719: Patch

https://bugs.webkit.org/attachment.cgi?id=417719&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 417719
  --> https://bugs.webkit.org/attachment.cgi?id=417719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417719&action=review

>
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableIOSurfaceBacken
d.cpp:52
> +    if (result != kIOReturnSuccess)

This should be in ImageBufferShareableMappedIOSurfaceBackend, and /only/ in
ImageBufferShareableMappedIOSurfaceBackend.
ImageBufferShareableIOSurfaceBackend (the unmapped variant) by definition must
not IOSurfaceLookupFromMachPort.