[webkit-reviews] review granted: [Bug 220651] [GStreamer] Clean-up the TextSink : [Attachment 417692] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220651: [GStreamer] Clean-up the TextSink
https://bugs.webkit.org/show_bug.cgi?id=220651

Attachment 417692: Patch

https://bugs.webkit.org/attachment.cgi?id=417692&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 417692
  --> https://bugs.webkit.org/attachment.cgi?id=417692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417692&action=review

> Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:130
> +GstElement* webkitTextSinkNew(WeakPtr<MediaPlayerPrivateGStreamer> player)

I think you can && here and move when assigning to the priv