[webkit-reviews] review granted: [Bug 220651] [GStreamer] Clean-up the TextSink : [Attachment 417691] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220651: [GStreamer] Clean-up the TextSink
https://bugs.webkit.org/show_bug.cgi?id=220651

Attachment 417691: Patch

https://bugs.webkit.org/attachment.cgi?id=417691&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 417691
  --> https://bugs.webkit.org/attachment.cgi?id=417691
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417691&action=review

> Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:84
> +    g_object_set(priv->appSink.get(), "emit-signals", true,
"enable-last-sample", false, "caps", textCaps.get(), nullptr);

I think these should be TRUE and FALSE

> Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:88
> +	   auto sample =
adoptGRef(gst_app_sink_pull_sample(GST_APP_SINK(appSink)));
> +	   webkitTextSinkHandleSample(sink, WTFMove(sample));

What about webkitTextSinkHandleSample(sink,
adoptGRef(gst_app_sink_pull_sample(GST_APP_SINK(appSink)))); ?

> Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:94
> +	   auto sample =
adoptGRef(gst_app_sink_pull_preroll(GST_APP_SINK(appSink)));
> +	   webkitTextSinkHandleSample(sink, WTFMove(sample));

Ditto.