[webkit-reviews] review granted: [Bug 220630] Crash from CompositeEditCommand::moveParagraphs() being passed null end : [Attachment 417641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 17:25:24 PST 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 220630: Crash from CompositeEditCommand::moveParagraphs() being passed null
end
https://bugs.webkit.org/show_bug.cgi?id=220630

Attachment 417641: Patch

https://bugs.webkit.org/attachment.cgi?id=417641&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 417641
  --> https://bugs.webkit.org/attachment.cgi?id=417641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417641&action=review

> Source/WebCore/editing/InsertListCommand.cpp:303
> +    // Make sure there are valid positions in the paragraph to move.

I don't think this comment is necessary. It's pretty evident from the code why
we'd have to check it here.


More information about the webkit-reviews mailing list