[webkit-reviews] review granted: [Bug 220562] [webkitscmpy] Add GitHub credentials : [Attachment 417486] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 14 15:39:47 PST 2021


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 220562: [webkitscmpy] Add GitHub credentials
https://bugs.webkit.org/show_bug.cgi?id=220562

Attachment 417486: Patch

https://bugs.webkit.org/attachment.cgi?id=417486&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 417486
  --> https://bugs.webkit.org/attachment.cgi?id=417486
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417486&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:118
> +	   username, access_token = self.credentials(required=True if
authenticated else False)

required=bool(authenticated) ?


More information about the webkit-reviews mailing list