[webkit-reviews] review granted: [Bug 220474] Web Inspector: Font Details sidebar - Fractional variation axis ranges/default values are rounded. : [Attachment 417654] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 220474: Web Inspector: Font Details sidebar - Fractional variation axis
ranges/default values are rounded.
https://bugs.webkit.org/show_bug.cgi?id=220474

Attachment 417654: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=417654&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 417654
  --> https://bugs.webkit.org/attachment.cgi?id=417654
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=417654&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +	   - Add basic support for IEEE printf `g` which truncates trailing
zeros in the fractional portion of the number.

Are we sure that localizers will know what this is?

Aside: I wonder if we actually want to use this instead of `f` more often ��

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1096
> +	   g: function(substitution, token)

Please add some tests for this :)

IIRC there's tests for other stuff in
`LayoutTests/inspector/unit-tests/string-utilities.html`.

Style: you should be able to `g(substitution, token)` instead of having the `:
function` :)