[webkit-reviews] review granted: [Bug 220463] [GStreamer] Clean-up the TextCombiner : [Attachment 417620] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220463: [GStreamer] Clean-up the TextCombiner
https://bugs.webkit.org/show_bug.cgi?id=220463

Attachment 417620: Patch

https://bugs.webkit.org/attachment.cgi?id=417620&action=review




--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 417620
  --> https://bugs.webkit.org/attachment.cgi?id=417620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417620&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:142
> +    auto* internalPad =
webKitTextCombinerPadLeakInternalPadRef(combinerPad);
> +    gst_element_release_request_pad(combiner->priv->combinerElement.get(),
internalPad);
> +    gst_object_unref(internalPad);

Nit: I would adopt it here not unref. I would try to avoid manual unrefs as
much as possible cause they can lead to leaks if we change the code around and
forget to call it when it is due.