[webkit-reviews] review granted: [Bug 220472] [Mac] Netflix controls do not fade out after entering fullscreen : [Attachment 417583] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 13 17:38:16 PST 2021


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 220472: [Mac] Netflix controls do not fade out after entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=220472

Attachment 417583: Patch

https://bugs.webkit.org/attachment.cgi?id=417583&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 417583
  --> https://bugs.webkit.org/attachment.cgi?id=417583
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417583&action=review

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:401
> +	   // FIXME(53342): remove once pointer events fire when elements move
out from under the pointer.

2011!

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:408
> +	       eventNumber:0 clickCount:0 pressure:0];

Nit: is there any reason to not put these an separate lines like the others?


More information about the webkit-reviews mailing list