[webkit-reviews] review granted: [Bug 220596] PCM: Output logs by default, including to Web Inspector : [Attachment 417550] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 220596: PCM: Output logs by default, including to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=220596

Attachment 417550: Patch

https://bugs.webkit.org/attachment.cgi?id=417550&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 417550
  --> https://bugs.webkit.org/attachment.cgi?id=417550
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417550&action=review

r=me

> Source/WebCore/loader/PrivateClickMeasurement.cpp:65
> +	   return makeUnexpected("[Private Click Measurement] Conversion was
not accepted because the URL's protocol is not HTTPS or the URL contains one or
more of username, password, query string, and fragment."_s);

Do we need to do any kind of feature check to decide whether to handle the
attribution requests? Or does the flag only controlling emitting the report?

After thinking about it, I think that makes good sense since a developer could
test (and see this output in WebInspector) without actually triggering any
conversion events.