[webkit-reviews] review granted: [Bug 220573] PCM: Experimental debug mode needs to be read from defaults differently on iOS : [Attachment 417499] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 220573: PCM: Experimental debug mode needs to be read from defaults
differently on iOS
https://bugs.webkit.org/show_bug.cgi?id=220573

Attachment 417499: Patch

https://bugs.webkit.org/attachment.cgi?id=417499&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 417499
  --> https://bugs.webkit.org/attachment.cgi?id=417499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417499&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:497
> +#if PLATFORM(IOS)

I would suggest #elif PLATFORM(IOS).

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:498
> +    parameters.enablePrivateClickMeasurementDebugMode = [defaults
boolForKey:[NSString stringWithFormat:@"WebKitExperimental%@",
WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString(
).get()]];

Sometimes we do #else with a "notImplemented()" but it's probably not warranted
in this case.