[webkit-reviews] review granted: [Bug 220586] [buildbot] WebKitGTK(GTK4) isn't triggered after a binary build : [Attachment 417521] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 220586: [buildbot] WebKitGTK(GTK4) isn't triggered after a binary build
https://bugs.webkit.org/show_bug.cgi?id=220586

Attachment 417521: Patch

https://bugs.webkit.org/attachment.cgi?id=417521&action=review




--- Comment #2 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 417521
  --> https://bugs.webkit.org/attachment.cgi?id=417521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417521&action=review

looks good, just need to change the triggerable name.

> Tools/CISupport/build-webkit-org/config.json:336
> +				      "gtk-linux-64-release-wayland-tests",
"gtk-linux-64-release-perf-tests", "gtk-linux-64-release-gtk4"],

please append "-tests" at at end of triggerable name to match with other
similar names.

> Tools/CISupport/build-webkit-org/config.json:647
> +		       { "type": "Triggerable", "name":
"gtk-linux-64-release-gtk4",

ditto.