[webkit-reviews] review granted: [Bug 220550] REGRESSION (r267571): black line appears upon navigating back from apple.com shopping bag : [Attachment 417476] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 13 01:43:58 PST 2021
Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 220550: REGRESSION (r267571): black line appears upon navigating back from
apple.com shopping bag
https://bugs.webkit.org/show_bug.cgi?id=220550
Attachment 417476: Patch
https://bugs.webkit.org/attachment.cgi?id=417476&action=review
--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 417476
--> https://bugs.webkit.org/attachment.cgi?id=417476
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=417476&action=review
Looks good
> Source/WebCore/dom/Element.cpp:3320
> + if (pseudoId == PseudoId::None) {
I'd reverse the test so the main body of the function is the usual None case.
More information about the webkit-reviews
mailing list