[webkit-reviews] review denied: [Bug 220529] Reimplement WebCore::isInWebProcess() family as cross-platform by using AuxiliaryProcessInitializationParameters.processType : [Attachment 417489] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 220529: Reimplement WebCore::isInWebProcess() family as cross-platform by
using AuxiliaryProcessInitializationParameters.processType
https://bugs.webkit.org/show_bug.cgi?id=220529

Attachment 417489: Patch

https://bugs.webkit.org/attachment.cgi?id=417489&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 417489
  --> https://bugs.webkit.org/attachment.cgi?id=417489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417489&action=review

> Source/WebCore/platform/RuntimeApplicationChecks.cpp:70
> +Optional<AuxiliaryProcessType> auxiliaryProcessType()

If this returns a const Optional<AuxiliaryProcessType>& you can have a function
scoped static variable instead of using possibly uninitialized memory if you
call checkAuxiliaryProcessType from the UI process.