[webkit-reviews] review granted: [Bug 220556] REGRESSION (r265044): [macOS] Safari autocorrects text when typing in login field on amazon.com : [Attachment 417478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 13:34:04 PST 2021


Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 220556: REGRESSION (r265044): [macOS] Safari autocorrects text when typing
in login field on amazon.com
https://bugs.webkit.org/show_bug.cgi?id=220556

Attachment 417478: Patch

https://bugs.webkit.org/attachment.cgi?id=417478&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 417478
  --> https://bugs.webkit.org/attachment.cgi?id=417478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417478&action=review

> Source/WebKit/ChangeLog:11
> +	   Restores the implementation of
`WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled`, which was removed in
> +	   r265044, with the reasoning that the code was unused. However,
Safari still uses this SPI on macOS to prevent
> +	   automatic spelling correction from triggering when editing form
fields that are AutoFillable.

Wow, how did I miss that?

Was that the only mistake of the 12 functions that I claimed were unused?


More information about the webkit-reviews mailing list