[webkit-reviews] review granted: [Bug 220372] [WebGL2] fbostatequery, negativebufferapi, negativevertexarrayapi, shaderstatequery conformance failures : [Attachment 417423] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 220372: [WebGL2] fbostatequery, negativebufferapi, negativevertexarrayapi,
shaderstatequery conformance failures
https://bugs.webkit.org/show_bug.cgi?id=220372

Attachment 417423: Patch

https://bugs.webkit.org/attachment.cgi?id=417423&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 417423
  --> https://bugs.webkit.org/attachment.cgi?id=417423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417423&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1745
> +    // Determine the number of elements the bound buffer can hold, given the
offset, size, type and stride

Nit: End with period.

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:2055
> +    if (isContextLostOrPending() || !sampler ||
!sampler->validate(contextGroup(), *this) || sampler->isDeleted())

Can a sampler be valid if it is deleted? If not, can we delete the last test
here?

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:-2085
> -    if (isContextLostOrPending() || !sync || sync->isDeleted() ||
!validateWebGLObject("deleteSync", sync))
> -	   return;

Is it ok to delete this?