[webkit-reviews] review granted: [Bug 209332] [GStreamer] Lazy initialization support : [Attachment 417373] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 209332: [GStreamer] Lazy initialization support
https://bugs.webkit.org/show_bug.cgi?id=209332

Attachment 417373: Patch

https://bugs.webkit.org/attachment.cgi?id=417373&action=review




--- Comment #32 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 417373
  --> https://bugs.webkit.org/attachment.cgi?id=417373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417373&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:245
> -bool initializeGStreamer(Optional<Vector<String>>&& options)
> +bool ensureGStreamerInitialized()
>  {
>      static std::once_flag onceFlag;
>      static bool isGStreamerInitialized;
> -    std::call_once(onceFlag, [options = WTFMove(options)] {
> +    std::call_once(onceFlag, [] {
>	   isGStreamerInitialized = false;

Please add a release assert to ensure this is only called in he web process