[webkit-reviews] review granted: [Bug 220312] [selectors] Update tests from WPT : [Attachment 417436] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 12 00:52:07 PST 2021


Sergio Villar Senin <svillar at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 220312: [selectors] Update tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=220312

Attachment 417436: Patch

https://bugs.webkit.org/attachment.cgi?id=417436&action=review




--- Comment #11 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 417436
  --> https://bugs.webkit.org/attachment.cgi?id=417436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417436&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log:12
> +appearance

Not sure what this is about...

> LayoutTests/platform/glib/TestExpectations:199
> +webkit.org/b/185859
imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html [ Pass ]

Wouldn't it make more sense to disable them on Mac instead of Skip + Pass here?


More information about the webkit-reviews mailing list