[webkit-reviews] review granted: [Bug 218688] Receiving two enter/exit fullscreen delegate callbacks on iPad when presenting fullscreen elements : [Attachment 413537] WIP patch (need an API test)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 218688: Receiving two enter/exit fullscreen delegate callbacks on iPad when
presenting fullscreen elements
https://bugs.webkit.org/show_bug.cgi?id=218688

Attachment 413537: WIP patch (need an API test)

https://bugs.webkit.org/attachment.cgi?id=413537&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 413537
  --> https://bugs.webkit.org/attachment.cgi?id=413537
WIP patch (need an API test)

View in context: https://bugs.webkit.org/attachment.cgi?id=413537&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:936
> +    if (mode == HTMLMediaElementEnums::VideoFullscreenModeNone && standby)
> +	   m_changingStandbyOnly = true;
> +    else
> +	   m_changingStandbyOnly = false;

m_changingStandbyOnly = mode == HTMLMediaElementEnums::VideoFullscreenModeNone
&& standby;

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:972
> +    if (!m_currentMode.hasVideo() && m_standby)
> +	   m_changingStandbyOnly = true;
> +    else
> +	   m_changingStandbyOnly = false;

m_changingStandbyOnly = !m_currentMode.hasVideo() && m_standby;