[webkit-reviews] review granted: [Bug 220058] Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons : [Attachment 416998] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 220058: Unmuting a track in case of end of interruption by another web
process tab is not working well with capture muting icons
https://bugs.webkit.org/show_bug.cgi?id=220058

Attachment 416998: Patch

https://bugs.webkit.org/attachment.cgi?id=416998&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 416998
  --> https://bugs.webkit.org/attachment.cgi?id=416998
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416998&action=review

> Source/WebCore/ChangeLog:20
> +	   When an interruption ends, all capture tracks are updated accorsing
the page muted state, which is controlled by UIProcess.

s/updated accorsing the page/updated according to the page/

> Source/WebKit/ChangeLog:172
> -2020-12-22  Youenn Fablet  <youenn at apple.com>
> +2020-12-21  Youenn Fablet  <youenn at apple.com>

Is this change intentional?

> Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:487
> +	   // We can only have one source at a time: we can mute all tracks but
unmute only one of them.

Nit: this and the comment below are duplicated in the audio and video loops,
they could be moved up above instead.