[webkit-reviews] review denied: [Bug 218093] [css-logical] Implement logical border-radius : [Attachment 417266] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 11 10:28:42 PST 2021

Simon Fraser (smfr) <simon.fraser at apple.com> has denied zsun at igalia.com's
request for review:
Bug 218093: [css-logical] Implement logical border-radius

Attachment 417266: Patch


--- Comment #46 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 417266
  --> https://bugs.webkit.org/attachment.cgi?id=417266

View in context: https://bugs.webkit.org/attachment.cgi?id=417266&action=review

> Source/WebCore/css/CSSProperty.cpp:63
> +static CSSPropertyID resolveToPhysicalProperty(TextDirection direction,
WritingMode writingMode, LogicalBoxCorner logicalBoxCorner, const
StylePropertyShorthand& shorthand)
> +{
> +    return
eTextFlow(writingMode, direction), logicalBoxCorner))];
> +}

This code is unsafe. If it's called with some random StylePropertyShorthand
(not border-radius) then it can run off the end of the properties() array.

Since you only call this for borderRadiusShorthand(), make it explicitly about

More information about the webkit-reviews mailing list