[webkit-reviews] review granted: [Bug 220492] TypedArray's [[DefineOwnProperty]] should throw in case of failure : [Attachment 417324] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 220492: TypedArray's [[DefineOwnProperty]] should throw in case of failure
https://bugs.webkit.org/show_bug.cgi?id=220492

Attachment 417324: Patch

https://bugs.webkit.org/attachment.cgi?id=417324&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 417324
  --> https://bugs.webkit.org/attachment.cgi?id=417324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417324&action=review

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:409
> +	       typename Adaptor::Type value =
toNativeFromValue<Adaptor>(globalObject, descriptor.value());

Do we really need Adaptor::Type here. Would auto work?