[webkit-reviews] review denied: [Bug 199661] Allow MediaStream and non MediaStream backed videos to play together : [Attachment 408906] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 199661: Allow MediaStream and non MediaStream backed videos to play
together
https://bugs.webkit.org/show_bug.cgi?id=199661

Attachment 408906: Patch

https://bugs.webkit.org/attachment.cgi?id=408906&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 408906
  --> https://bugs.webkit.org/attachment.cgi?id=408906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408906&action=review

> Source/WebCore/platform/audio/PlatformMediaSession.cpp:356
> -    return m_client.hasMediaStreamSource() &&
otherSession.m_client.hasMediaStreamSource();
> +    return m_client.hasMediaStreamSource() ||
otherSession.m_client.hasMediaStreamSource();

I don't think this is correct; we shouldn't allow a Media Stream in one
document context to play simultaneously to a YouTube video in an entirely
separate document context.  Can we narrow this to enable playback only when the
two sessions are both in the same document?