[webkit-reviews] review granted: [Bug 220137] Failures of attribute location conformance tests with Metal backend : [Attachment 417308] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 220137: Failures of attribute location conformance tests with Metal backend
https://bugs.webkit.org/show_bug.cgi?id=220137

Attachment 417308: Patch

https://bugs.webkit.org/attachment.cgi?id=417308&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 417308
  --> https://bugs.webkit.org/attachment.cgi?id=417308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417308&action=review

Looks good if the unrelated changes are removed.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:-126
> -
> -// NOTE(hqle): support variable max number of vertex attributes
> -constexpr uint32_t kMaxVertexAttribs = gl::MAX_VERTEX_ATTRIBS;
> -// NOTE(hqle): support variable max number of render targets
> -constexpr uint32_t kMaxRenderTargets = 4;
> -

I don't think you meant to include the changes in this file.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_constants.h:35
> +constexpr uint32_t kMaxShaderXFBs =
gl::IMPLEMENTATION_MAX_TRANSFORM_FEEDBACK_SEPARATE_ATTRIBS;
> +
> +// The max size of a buffer that will be allocated in shared memory.
> +// NOTE(hqle): This is just a hint. There is no official document on what is
the max allowed size
> +// for shared memory.
> +constexpr size_t kSharedMemBufferMaxBufSizeHint = 128 * 1024;

I think this is from another patch.