[webkit-reviews] review granted: [Bug 217118] REGRESSION(r267402): [ macOS iOS Release ] imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html is a flaky failure : [Attachment 417279] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 11:56:35 PST 2021


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 217118: REGRESSION(r267402): [ macOS iOS Release ]
imported/w3c/web-platform-tests/user-timing/measure-l3.any.worker.html is a
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=217118

Attachment 417279: Patch

https://bugs.webkit.org/attachment.cgi?id=417279&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 417279
  --> https://bugs.webkit.org/attachment.cgi?id=417279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417279&action=review

> LayoutTests/imported/w3c/web-platform-tests/user-timing/measure-l3.any.js:25
> +  assert_greater_than_equal(Number(endTime(measureEntry).toFixed(2)),
endMin);
> +  assert_greater_than_equal(endMax,
Number(endTime(measureEntry).toFixed(2)));

Would it be better to do this by subtraction and picking a maximum delta
instead?


More information about the webkit-reviews mailing list