[webkit-reviews] review granted: [Bug 220406] Service Worker is no longer inspectable : [Attachment 417264] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 220406: Service Worker is no longer inspectable
https://bugs.webkit.org/show_bug.cgi?id=220406

Attachment 417264: Patch

https://bugs.webkit.org/attachment.cgi?id=417264&action=review




--- Comment #15 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 417264
  --> https://bugs.webkit.org/attachment.cgi?id=417264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417264&action=review

Great, thanks for fixing! R=me.

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:225
> +void WebProcessProxy::enableRemoteInspectorIfNeeded()
> +{
> +    if (!shouldEnableRemoteInspector())
> +	   return;
> +    send(Messages::WebProcess::EnableRemoteWebInspector(), 0);

It this function still needed? It could be useful when we implement observation
of the Develop menu preference key.