[webkit-reviews] review granted: [Bug 220347] Stop using MediaRecorder in API test WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage : [Attachment 417100] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 220347: Stop using MediaRecorder in API test
WebKit2.SpeechRecognitionErrorWhenStartingAudioCaptureOnDifferentPage
https://bugs.webkit.org/show_bug.cgi?id=220347

Attachment 417100: Patch

https://bugs.webkit.org/attachment.cgi?id=417100&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 417100
  --> https://bugs.webkit.org/attachment.cgi?id=417100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417100&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SpeechRecognition.mm:34
> +#import <WebKit/_WKExperimentalFeature.h>

No longer needed.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/speechrecognition-basic.html:32
> +	   };

I would simplify this and just do:
audio.play();
It might be best also to add the audio element to the DOM.
Maybe just add something like:
<audio id="audio" autoplay></audio>
And then write audio.play() here.