[webkit-reviews] review granted: [Bug 220451] [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge : [Attachment 417235] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 19:07:25 PST 2021


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 220451: [JSC] DFG/FTL Atomics should assume non-typed-array input with
storage-edge
https://bugs.webkit.org/show_bug.cgi?id=220451

Attachment 417235: Patch

https://bugs.webkit.org/attachment.cgi?id=417235&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 417235
  --> https://bugs.webkit.org/attachment.cgi?id=417235
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review

r=me with ChangeLog fix.

> Source/JavaScriptCore/ChangeLog:11
> +	   and if it is, we should make it generic one instead of using fast
TypedArray path.

I think you meant to say "if it is not" instead here.


More information about the webkit-reviews mailing list