[webkit-reviews] review granted: [Bug 220429] [JSC] New expression and value function call should reserve function register if arguments include assignments : [Attachment 417204] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 220429: [JSC] New expression and value function call should reserve
function register if arguments include assignments
https://bugs.webkit.org/show_bug.cgi?id=220429

Attachment 417204: Patch

https://bugs.webkit.org/attachment.cgi?id=417204&action=review




--- Comment #4 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 417204
  --> https://bugs.webkit.org/attachment.cgi?id=417204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417204&action=review

This is handsome, nicely done!

> Source/JavaScriptCore/ChangeLog:17
> +	       2. function value call (it is checking `isLocation()`, but we
can still use local variables for function if we use comma expression)

Tagged template literals are already correct:

    x`_${x = 1}_`

Would be nice to have a test for it (if there is none).