[webkit-reviews] review granted: [Bug 220394] Use smart pointers in UIDelegate and NavigationState : [Attachment 417198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 12:50:07 PST 2021


Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 220394: Use smart pointers in UIDelegate and NavigationState
https://bugs.webkit.org/show_bug.cgi?id=220394

Attachment 417198: Patch

https://bugs.webkit.org/attachment.cgi?id=417198&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 417198
  --> https://bugs.webkit.org/attachment.cgi?id=417198
Patch

r=me

Smart pointer is definitely better than raw pointer here. Would be nice in the
future just to make this lifetime mismatch impossible.


More information about the webkit-reviews mailing list