[webkit-reviews] review granted: [Bug 220411] PaintFrameForMedia has a null identifier when media player is a media stream track video player : [Attachment 417176] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 10:03:54 PST 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 220411: PaintFrameForMedia has a null identifier when media player is a
media stream track video player
https://bugs.webkit.org/show_bug.cgi?id=220411

Attachment 417176: Patch

https://bugs.webkit.org/attachment.cgi?id=417176&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 417176
  --> https://bugs.webkit.org/attachment.cgi?id=417176
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review

> Source/WebCore/platform/graphics/GraphicsContextImpl.h:108
> +    virtual bool canPaintFrameForMedia(const MediaPlayer&) const = 0;

I think you'll need to update this method for other platforms as well (i.e.
Windows, Cairo, Nicosia).


More information about the webkit-reviews mailing list