[webkit-reviews] review granted: [Bug 219495] IntersectionObserver {root:document}: Getting a different rootBounds.top than both FF/Chrome for a scrolled window : [Attachment 417177] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted cathiechen <cathiechen at igalia.com>'s
request for review:
Bug 219495: IntersectionObserver {root:document}: Getting a different
rootBounds.top than both FF/Chrome for a scrolled window
https://bugs.webkit.org/show_bug.cgi?id=219495

Attachment 417177: Patch

https://bugs.webkit.org/attachment.cgi?id=417177&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 417177
  --> https://bugs.webkit.org/attachment.cgi?id=417177
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417177&action=review

> Source/WebCore/dom/Document.cpp:7675
> +	   else if (observer.root() == &target.document())
> +	       localRootBounds = frameView.layoutViewportRect();

Is this exactly the right place for the check check? Should it be before the
hasOverflowClip or before the isContainingBlockAncestorFor check?

Is the single test case in WPT sufficient coverage?