[webkit-reviews] review denied: [Bug 220394] Protect WebPageProxy in didFinishLoadForFrame : [Attachment 417144] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 220394: Protect WebPageProxy in didFinishLoadForFrame
https://bugs.webkit.org/show_bug.cgi?id=220394

Attachment 417144: Patch

https://bugs.webkit.org/attachment.cgi?id=417144&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 417144
  --> https://bugs.webkit.org/attachment.cgi?id=417144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417144&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:4770
> +    auto protectedThis = makeRef(*this);

This is unnecessary in functions called via IPC. We solved it at a global level
years ago. If you look at WebPageProxy::didReceiveMessage() in generated code,
you will see:
auto protectedThis = makeRef(*this);

We protect the WebPageProxy while calling every function due to an IPC message.