[webkit-reviews] review granted: [Bug 220314] [WASM-References] Add linking tests : [Attachment 416979] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 220314: [WASM-References] Add linking tests
https://bugs.webkit.org/show_bug.cgi?id=220314

Attachment 416979: Patch

https://bugs.webkit.org/attachment.cgi?id=416979&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416979
  --> https://bugs.webkit.org/attachment.cgi?id=416979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416979&action=review

r=me, but we need to have bugzilla links.

> JSTests/wasm/references-spec-tests/linking.wast.js:269
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133. should be
uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

When commenting out wasm spec test, we should have bugzilla URL with FIXME
which clarifies what is the problem and how we will fix in the future.
And the comment has duplicate information twice.

> JSTests/wasm/references-spec-tests/linking.wast.js:279
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:290
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:353
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:391
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:402
> +// FIXME: should be uninstantiable -
https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.