[webkit-reviews] review granted: [Bug 220341] [Cocoa] Revert audioTimePitchAlgorithm to "TimeDomain" from "Spectral" : [Attachment 417042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 01:40:19 PST 2021


youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 220341: [Cocoa] Revert audioTimePitchAlgorithm to "TimeDomain" from
"Spectral"
https://bugs.webkit.org/show_bug.cgi?id=220341

Attachment 417042: Patch

https://bugs.webkit.org/attachment.cgi?id=417042&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 417042
  --> https://bugs.webkit.org/attachment.cgi?id=417042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417042&action=review

> Source/WebCore/ChangeLog:11
> +	   Revert to "TimeDomain", which is both more computationally
inexpensive, and both propogates

s/propogates/propagates/

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:1722
> +  webcoreBinding: custom

Can we remove that one so that we let WebPage::updateSettingsGenerated update
the corresponding settings directly?
Or maybe it is due to the Settings being typed as
MediaPlayerEnums::PitchCorrectionAlgorithm.
Might be nice for the pref generator to handle this code without static_cast
below.
That might remove some webcoreBinding custom code as well.
Maybe Sam has some ideas here?

> Source/WebCore/html/HTMLMediaElement.cpp:1450
> +   
m_player->setPitchCorrectionAlgorithm(static_cast<MediaPlayer::PitchCorrectionA
lgorithm>(document().settings().pitchCorrectionAlgorithm()));

Do we really need this static_cast?


More information about the webkit-reviews mailing list