[webkit-reviews] review granted: [Bug 220336] PCM: Experimental debug mode stops working after initial use : [Attachment 417035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 14:30:13 PST 2021


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 220336: PCM: Experimental debug mode stops working after initial use
https://bugs.webkit.org/show_bug.cgi?id=220336

Attachment 417035: Patch

https://bugs.webkit.org/attachment.cgi?id=417035&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 417035
  --> https://bugs.webkit.org/attachment.cgi?id=417035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417035&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327
> +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled)

Is this always called on NetworkProcess initialization? And I assume toggling
the setting switch in UIProcess sends a message that hits this?


More information about the webkit-reviews mailing list