[webkit-reviews] review granted: [Bug 220236] WebKit IPC generator tests have duplicate receiver names, limiting the implementation : [Attachment 416935] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 5 12:19:58 PST 2021


Chris Dumez <cdumez at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 220236: WebKit IPC generator tests have duplicate receiver names, limiting
the implementation
https://bugs.webkit.org/show_bug.cgi?id=220236

Attachment 416935: Patch

https://bugs.webkit.org/attachment.cgi?id=416935&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 416935
  --> https://bugs.webkit.org/attachment.cgi?id=416935
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416935&action=review

r=me

> Source/WebKit/Scripts/MessageNames.h:-31
> -enum class ReceiverName : uint8_t {

Having WebPage 3 times in this enum indeed seemed bogus.


More information about the webkit-reviews mailing list