[webkit-reviews] review granted: [Bug 205675] Support lab(), lch(), gray() and color(lab ...) colors : [Attachment 416916] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 205675: Support lab(), lch(), gray() and color(lab ...) colors
https://bugs.webkit.org/show_bug.cgi?id=205675

Attachment 416916: Patch

https://bugs.webkit.org/attachment.cgi?id=416916&action=review




--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 416916
  --> https://bugs.webkit.org/attachment.cgi?id=416916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416916&action=review

Would be nice to have some ref tests that show that the color conversions work
correctly.

> Source/WebCore/ChangeLog:70
> +	   Add Lab to callWithColorType sinc it is now a valid ColorSpace.

sinc

> Source/WebCore/platform/graphics/Color.h:61
>  //	 - 4x float (0-1) Linear sRGBA, stored in a reference counted
sub-object
>  //	 - 4x float (0-1) DisplayP3, stored in a reference counted sub-object
> +//	 - 4x float (0-1) Lab, stored in a reference counted sub-object

It's a bit weird that we spell all these out here.