[webkit-reviews] review granted: [Bug 220112] REGRESSION[r270947][GStreamer]: Deadlocks audio rendering : [Attachment 416749] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220112: REGRESSION[r270947][GStreamer]: Deadlocks audio rendering
https://bugs.webkit.org/show_bug.cgi?id=220112

Attachment 416749: Patch

https://bugs.webkit.org/attachment.cgi?id=416749&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 416749
  --> https://bugs.webkit.org/attachment.cgi?id=416749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416749&action=review

> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h:59
> +    Optional<CompletionHandler<void(bool)>> m_startupCompletionHandler;

Does not need to be Optional<>. CompletionHandler has a null state.

> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h:60
> +    Optional<CompletionHandler<void(bool)>> m_stopCompletionHandler;

Ditto.