[webkit-reviews] review granted: [Bug 220133] Fail speech recognition when page is muted for audio capture : [Attachment 416975] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 220133: Fail speech recognition when page is muted for audio capture
https://bugs.webkit.org/show_bug.cgi?id=220133

Attachment 416975: Patch

https://bugs.webkit.org/attachment.cgi?id=416975&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 416975
  --> https://bugs.webkit.org/attachment.cgi?id=416975
Patch

Looks good overall.
Some style improvements below.

View in context: https://bugs.webkit.org/attachment.cgi?id=416975&action=review

> Source/WebKit/ChangeLog:11
> +	   1. when page is muted, mute audio capture source used for speech
recognition audion on the page. This will

s/audion/audio/

> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:73
> +    }

I am not sure we need to create a HashSet here.
We could either add a
SpeechRecognitionPermissionManager::muteCaptureExceptIn(WebPageProxy&) or rely
on WebProcessProxy::globalPageMap() and remove
UserMediaProcessManager::muteCaptureMediaStreamsExceptIn

> Source/WebKit/UIProcess/WebProcessProxy.cpp:1779
> +    speechRecognitionServer->mute();

I would write it as if (auto ...)