[webkit-reviews] review granted: [Bug 220248] [LFC Display] Add a Display::Box flag for HasTransfrom : [Attachment 416953] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 220248: [LFC Display] Add a Display::Box flag for HasTransfrom
https://bugs.webkit.org/show_bug.cgi?id=220248

Attachment 416953: Patch

https://bugs.webkit.org/attachment.cgi?id=416953&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 416953
  --> https://bugs.webkit.org/attachment.cgi?id=416953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416953&action=review

> Source/WebCore/ChangeLog:10
> +	   It's possible for a non-box model box to have a RenderStyle with a
transform, but that
> +	   style isn't applied because transforms only apply to atomic inline
or block boxes,
> +	   so store a bit on Box for boxes that have transforms.

This seems like really useful information to include as a comment in the header
explaining why the state is seemingly potentially duplicated.